From 2dffb2c03ed4001d00a0b60341e30a70aab54c05 Mon Sep 17 00:00:00 2001 From: Simon Schneider <10846939+raynigon@users.noreply.github.com> Date: Mon, 19 Sep 2022 11:49:47 +0200 Subject: [PATCH] Replace ADD with COPY (#5029) Its a best practice to use the COPY statement instead of ADD. See https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#add-or-copy for more information --- Dockerfile | 2 +- cmd/admission-webhook/Dockerfile | 2 +- cmd/prometheus-config-reloader/Dockerfile | 2 +- example/alertmanger-webhook/Dockerfile | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Dockerfile b/Dockerfile index 877da4745..467df67f1 100644 --- a/Dockerfile +++ b/Dockerfile @@ -2,7 +2,7 @@ ARG ARCH="amd64" ARG OS="linux" FROM quay.io/prometheus/busybox-${OS}-${ARCH}:latest -ADD operator /bin/operator +COPY operator /bin/operator # On busybox 'nobody' has uid `65534' USER 65534 diff --git a/cmd/admission-webhook/Dockerfile b/cmd/admission-webhook/Dockerfile index ebaa0b4d2..613dc084e 100644 --- a/cmd/admission-webhook/Dockerfile +++ b/cmd/admission-webhook/Dockerfile @@ -2,7 +2,7 @@ ARG ARCH="amd64" ARG OS="linux" FROM quay.io/prometheus/busybox-${OS}-${ARCH}:latest -ADD admission-webhook /bin/admission-webhook +COPY admission-webhook /bin/admission-webhook USER nobody diff --git a/cmd/prometheus-config-reloader/Dockerfile b/cmd/prometheus-config-reloader/Dockerfile index 2e948727c..0e5e367d2 100644 --- a/cmd/prometheus-config-reloader/Dockerfile +++ b/cmd/prometheus-config-reloader/Dockerfile @@ -2,7 +2,7 @@ ARG ARCH="amd64" ARG OS="linux" FROM quay.io/prometheus/busybox-${OS}-${ARCH}:latest -ADD prometheus-config-reloader /bin/prometheus-config-reloader +COPY prometheus-config-reloader /bin/prometheus-config-reloader USER nobody diff --git a/example/alertmanger-webhook/Dockerfile b/example/alertmanger-webhook/Dockerfile index 7415db13a..180cde804 100644 --- a/example/alertmanger-webhook/Dockerfile +++ b/example/alertmanger-webhook/Dockerfile @@ -1,5 +1,5 @@ FROM quay.io/prometheus/busybox:latest -ADD main /bin/main +COPY main /bin/main ENTRYPOINT ["/bin/main"]