mirror of
https://github.com/containers/ramalama.git
synced 2026-02-05 15:47:26 +01:00
eb3adbf5c8
Address code review feedback to separate content from build logic:
Changes:
- Created scripts/macos-installer/ directory for template files
- Moved distribution.xml to distribution.xml.template
* Uses {{VERSION}} and {{PKG_NAME}} placeholders
* Processed with sed during build
- Moved welcome.html to separate file
- Moved readme.html to separate file
- Moved conclusion.html to separate file
- Updated build_macos_pkg.sh to copy from templates
Benefits:
- Cleaner separation of content and build logic
- Easier to maintain and update installer UI text
- Templates can be edited without touching shell script
- More maintainable for future updates
- Follows best practices for build scripts
The build process now:
1. Copies HTML files as-is
2. Processes XML template with variable substitution
3. Builds installer with processed files
Cursor-AI-Generated
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>