containers/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2026-02-05 15:45:08 +01:00
Code Issues Releases Wiki Activity

fix: use localhost for host.containers.internal in host network mode

Browse Source 
Signed-off-by: Alessio Attilio <attilio.alessio@protonmail.com>
This commit is contained in:
Alessio Attilio
2026-02-02 18:32:24 +01:00
parent 2467b71c4a
commit fae93fe483
3 changed files with 31 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
libpod/container.go
View File

@@ -1301,7 +1301,16 @@ func (c *Container) NetworkDisabled() (bool, error) {
}
func (c *Container) HostNetwork() bool {
if c.config.CreateNetNS || c.config.NetNsCtr != "" {
// If container shares network namespace with another container, check that container
if c.config.NetNsCtr != "" {
netNsCtr, err := c.runtime.state.Container(c.config.NetNsCtr)
if err != nil {
return false
}
return netNsCtr.HostNetwork()
}
if c.config.CreateNetNS {
return false
}
if c.config.Spec.Linux != nil {

1
libpod/container_internal_common.go
View File

@@ -2427,6 +2427,7 @@ func (c *Container) addHosts() error {
NetworkInterface: c.runtime.network,
Exclude: exclude,
PreferIP: preferIP,
HostNetwork: c.HostNetwork(),
})
return etchosts.New(&etchosts.Params{

20
test/system/500-networking.bats
View File

@@ -773,6 +773,26 @@ nameserver 8.8.8.8" "nameserver order is correct"
run_podman network rm -f $netname
}
# https://github.com/containers/podman/issues/27823
# bats test_tags=ci:parallel
@test "podman run --network=host uses localhost for host.containers.internal" {
run_podman run --rm --network=host $IMAGE cat /etc/hosts
assert "$output" =~ "127\.0\.0\.1[[:blank:]].*host\.containers\.internal" \
"host.containers.internal should resolve to 127.0.0.1 with --network=host"
}
# https://github.com/containers/podman/pull/27927
# bats test_tags=ci:parallel
@test "podman run in pod with host network uses localhost for host.containers.internal" {
local podname="test-pod-hostnet-$(random_string 10)"
run_podman pod create --name $podname --network host
run_podman run --rm --pod $podname $IMAGE cat /etc/hosts
assert "$output" =~ "127\.0\.0\.1[[:blank:]].*host\.containers\.internal" \
"host.containers.internal should resolve to 127.0.0.1 in pod with host network"
run_podman pod rm $podname
}
# bats test_tags=ci:parallel
@test "podman run port forward range" {
# we run a long loop of tests lets run all combinations before bailing out