containers/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2026-02-05 15:45:08 +01:00
Code Issues Releases Wiki Activity
Files
b60d234da4266d7ce08b950a68dc2c37844b018c
podman/.pre-commit-config.yaml

30 lines
1.3 KiB
YAML
Raw Normal View History

Enable pre-commit tool linting This should help use keep the codebase more consistent, and avoid sevel whitespace related issues, or bad file permissions. pre-commit allows us to easily introduce other linters in follow-ups, like bashate. Note: pre-commit tool does *not* install any git-hooks. Making commits will will call the tool unless you deliverately tell it to install the hooks. Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
2020-01-07 20:46:18 +00:00
---
exclude new tools vendor dir from validate We have no control over the code in the vendored files. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-05-04 15:01:23 +02:00
exclude: ^vendor/|^test/tools/vendor/
Enable pre-commit tool linting This should help use keep the codebase more consistent, and avoid sevel whitespace related issues, or bad file permissions. pre-commit allows us to easily introduce other linters in follow-ups, like bashate. Note: pre-commit tool does *not* install any git-hooks. Making commits will will call the tool unless you deliverately tell it to install the hooks. Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
2020-01-07 20:46:18 +00:00
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks.git
Update pre-commit-hooks and Codespell hook pre-commit-hooks v3.4.0 -> v5.0.0 codespell 2.3.0 -> 3.4.1 Signed-off-by: Lewis Roy <lewis@redhat.com>
2025-04-09 14:14:28 +10:00
rev: v5.0.0
Enable pre-commit tool linting This should help use keep the codebase more consistent, and avoid sevel whitespace related issues, or bad file permissions. pre-commit allows us to easily introduce other linters in follow-ups, like bashate. Note: pre-commit tool does *not* install any git-hooks. Making commits will will call the tool unless you deliverately tell it to install the hooks. Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
2020-01-07 20:46:18 +00:00
hooks:
Add new targets on Windows makefile (winmake.ps1) Add the following targets in winmake.ps1: - `installer`: builds the Windows installer - `docs`: builds the documentation HTML pages - `validatepr`: runs the Linux Makefile `.valiatepr` target using podman. - `lint`: faster validation that runs linter locally Update of `build_windows.md`: - removed every reference to the MSYS2 platform - added instructions to build the installer and linters Fix https://github.com/containers/podman/issues/21821 and https://github.com/containers/podman/issues/21911 Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2024-05-08 11:59:55 +02:00
# `buildah-tests.diff` is generated by 'git format-patch' and includes
buildah bud tests under podman-remote New functionality -- mostly in the diffs we apply to buildah's helpers.bash -- to enable running buildah-bud tests under podman-remote. The gist of it is, we start a 'podman system service' before each test, and clean it up on test exit. Design decision: the diff file for helpers.bash is no longer trailing-whitespace-clean: that ended up producing diffs that git wouldn't apply, because in some cases the whitespace is actually important. In order to pass CI, we need to exclude this file from some checks. Signed-off-by: Ed Santiago <santiago@redhat.com>
2021-02-09 14:33:19 -07:00
# trailing whitespace as part of its format. We can work around that,
# but unfortunately the buildah repo has some files with tabs, which
# git-diff formats as '[+/-]<space><tab>', which these hooks choke on.
Exclude symlink from pre-commit end-of-file-fixer Git on Windows clones the symlink `test/python/requirements.txt` as a regular file. That's not a big deal except that `pre-commit`, executed by `winmake.ps1 lint`, complains because there is no new line at end of the file. To fix `winmake.ps1 lint` we exclude the symlink in `pre-commit` hook `end-of-file-fixer` configuration. Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2024-11-07 11:57:50 +01:00
# `contrib/systemd/user` and `test/python/requirements.txt` are symlinks
# but for some reason, on windows, pre-commit consider it as a regular
# file and tries to fix it. Just disable checks on these files as a
# special case.
Enable pre-commit tool linting This should help use keep the codebase more consistent, and avoid sevel whitespace related issues, or bad file permissions. pre-commit allows us to easily introduce other linters in follow-ups, like bashate. Note: pre-commit tool does *not* install any git-hooks. Making commits will will call the tool unless you deliverately tell it to install the hooks. Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
2020-01-07 20:46:18 +00:00
- id: end-of-file-fixer
Exclude symlink from pre-commit end-of-file-fixer Git on Windows clones the symlink `test/python/requirements.txt` as a regular file. That's not a big deal except that `pre-commit`, executed by `winmake.ps1 lint`, complains because there is no new line at end of the file. To fix `winmake.ps1 lint` we exclude the symlink in `pre-commit` hook `end-of-file-fixer` configuration. Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2024-11-07 11:57:50 +01:00
exclude: test/buildah-bud/buildah-tests.diff|contrib/systemd/user|test/python/requirements.txt
Enable pre-commit tool linting This should help use keep the codebase more consistent, and avoid sevel whitespace related issues, or bad file permissions. pre-commit allows us to easily introduce other linters in follow-ups, like bashate. Note: pre-commit tool does *not* install any git-hooks. Making commits will will call the tool unless you deliverately tell it to install the hooks. Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
2020-01-07 20:46:18 +00:00
- id: trailing-whitespace
Quadlet - fix trailing whitespaces handling Remove all trailing white spaces from all lines before the line by line processing Add test Exclude the unit file used for the test from whitespace check Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2023-12-31 11:53:53 +02:00
exclude: test/buildah-bud/buildah-tests.diff|test/e2e/quadlet/remap-keep-id2.container|test/e2e/quadlet/line-continuation-whitespace.container
Enable pre-commit tool linting This should help use keep the codebase more consistent, and avoid sevel whitespace related issues, or bad file permissions. pre-commit allows us to easily introduce other linters in follow-ups, like bashate. Note: pre-commit tool does *not* install any git-hooks. Making commits will will call the tool unless you deliverately tell it to install the hooks. Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
2020-01-07 20:46:18 +00:00
- id: mixed-line-ending
- id: check-byte-order-marker
- id: check-executables-have-shebangs
- id: check-merge-conflict
Cirrus: Simplify use of cache in automation With the increasingly complex `.cirrus.yml` task relationships, build cache wasn't always working as intended. Recently, non-build tasks were observed assuming authority over `gopath_cache`. Ref.: https://github.com/containers/podman/pull/13998#issuecomment-1108834538 Address this by an overall simplification using artifacts instead of cache. Using artifacts allows establishing concrete authorship/authority over cached repo. content. In this way, dependent tasks may simply consume the artifact with `curl` instead of relying on complex caching algorithms. Also/Minor: Add YAML checking to the pre-commit configuration. Signed-off-by: Chris Evich <cevich@redhat.com>
2022-04-25 14:45:40 -04:00
- id: check-yaml
pre-commit: exclude rpm/gating.yaml from check-yaml check-yaml for whatever reason doesn't like `!Policy` in rpm/gating.yaml. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2025-05-21 10:17:02 -04:00
exclude: rpm/gating.yaml
Add codespell config, pre-commit definition, and move options from Makefile Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
2024-07-24 10:29:12 -10:00
- repo: https://github.com/codespell-project/codespell
# Configuration for codespell is in .codespellrc
Update pre-commit-hooks and Codespell hook pre-commit-hooks v3.4.0 -> v5.0.0 codespell 2.3.0 -> 3.4.1 Signed-off-by: Lewis Roy <lewis@redhat.com>
2025-04-09 14:14:28 +10:00
rev: v2.4.1
Add codespell config, pre-commit definition, and move options from Makefile Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
2024-07-24 10:29:12 -10:00
hooks:
Update pre-commit-hooks and Codespell hook pre-commit-hooks v3.4.0 -> v5.0.0 codespell 2.3.0 -> 3.4.1 Signed-off-by: Lewis Roy <lewis@redhat.com>
2025-04-09 14:14:28 +10:00
- id: codespell
Copy Permalink