1
0
mirror of https://github.com/containers/netavark.git synced 2026-02-05 06:45:56 +01:00

15 Commits

Author SHA1 Message Date
Mario Loriedo
2355b14495 Minor documentation and style fixes
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2025-11-17 19:02:48 +01:00
Mario Loriedo
0fa48211bd Remove iptables support
Code and documentation changes to remove the support of
iptables as a firewall driver.

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2025-11-17 19:02:16 +01:00
Paul Holzinger
86686431eb docs/Makefile: several fixes
- build docs on install if needed
- clean should remove the .7 page
- add uninstall target so users can remove the pages from the system

Fixes #1179

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-02-18 17:03:24 +01:00
Matthew Heon
4fea4c01ed Finalize firewalld port forwarding support
There are two major changes here.

Firstly, this adds proper support for port forwarding from
localhost via a new policy accepting traffic from HOST. This is
the last bit we were missing from the original port-forwarding
implementation.

This requires two new zones: one in which the actual port forward
occurs, and one to allow traffic to 127.0.0.1 to be masqeuraded
so we can talk to the container from localhost.

Secondly, this fixes a bug where we generated incorrect rules
when port-forwarding from a single IP. Instead of doing standard
port-forwarding rules, those need rich rules. This was reported
as #881.

There are also some small code cleanups in how we handle setting
up and tearing down port forwarding. It's still rather ugly, but
at least a little better than it was before.

Fixes #881

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2025-02-07 10:43:37 -05:00
Matt Heon
6e5de55fc6 Add handling for firewalld's StrictForwardPorts setting
This mostly amounts to throwing a sensible error in cases where
the setting is enabled and the user has requested ports be
forwarded.

There are no tests at present because firewalld 2.3.x is
currently restricted to Rawhide, and is required for effective
testing.

A manpage has also been added with details on how to work with
the StrictForwardPorts setting (as well as some other tidbits on
firewalld + Podman integration).

Signed-off-by: Matt Heon <mheon@redhat.com>
2025-02-04 09:19:46 -05:00
Jake Correnti
1f75d87c3e Document how to generate a code coverage report for netavark
I documented how to generate a code coverage report using
coverage-profiling in the Rust compiler and the `grcov` tool created by
Mozilla. It generates an html version of the report that you can open in
the browser and navigate.

Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2024-01-03 13:11:31 -05:00
Ben Brown
6caef06f6c docs: Convert markdown with go-md2man instead of mandown
Closes #768.

Signed-off-by: Ben Brown <ben@demerara.io>
2023-08-09 18:15:12 +01:00
Brent Baude
8dc8c96793 Merge nv-dhcp-proxy into nv
The proxy is nearing completion and having them in separate repos has
become problematic geiven that they both "use" each other.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2023-03-06 15:35:17 +01:00
Paul Holzinger
bcb52afea8 CI: install mandown for validate
Add target to install mandown, also fixes useless `command -v` exucuting
in the makefile since it did't error out anyway when it was empty.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-12-14 17:46:58 +01:00
Paul Holzinger
97e90a3030 fix make docs
Regression caused by 011f899919. We only want to build actual man
pages of course and not general docs.
This commit fixes the wildcard target to only use the `.1.md` files
instead of all markdown files.
Also add the step to the validate target to make sure CI tests this
target.

Fixes #524

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-12-14 16:14:42 +01:00
Aditya R
011f899919 release,make: add rule crate-publish for publishing crates.io
* Add new rule `make crate-publish` to automate publish at https://crates.io/crates/netavark
* Document steps for publishing to `crates.io`

Signed-off-by: Aditya R <arajan@redhat.com>
2022-12-07 22:51:16 +05:30
Hosh Sadiq
e75cd79019 Fix Makefile for docs and main
Signed-off-by: Hosh Sadiq <hoshang.sadiq@gmail.com>
2022-07-19 10:55:34 +01:00
Paul Holzinger
cb9a15aeb1 Makefile: fix install target
Netavark should be installed into the podman libexec dir.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2021-10-26 19:01:44 +02:00
Lokesh Mandvekar
d2a855fd95 CI and Makefile updates
- Run rustfmt in `make validate` and CI validation
- Makefile: allow modification of PREFIX, DATADIR and MANDIR
- .cirrus.yml uses make targets instead of cargo commands
- Use `mandown` for manpage generation instead of `go-md2man`

Fixes: #33

Needs rustfmt and mandown crates installed in CI image.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2021-10-20 13:03:26 -04:00
Daniel J Walsh
2d461e397b Add man page and install to Makefile
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-10-14 10:59:01 -04:00