1
0
mirror of https://github.com/containers/buildah.git synced 2026-02-05 09:45:38 +01:00
Commit Graph

26 Commits

Author SHA1 Message Date
Nalin Dahyabhai
b6098a2c5c internal/mkcw/embed: cross-compile using Go
Use the Go toolchain to cross-compile the "This image is designed to be
run as a confidential workload using libkrun." entrypoint that we add to
confidential workload images.  It's bigger than it was before, but
easier to port and can be built from source every time when desired.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-11-06 10:46:23 -05:00
Lokesh Mandvekar
478c917837 RPM: build with sequoia on F43+
Follow up on #6390

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2025-10-17 11:33:34 -04:00
Nalin Dahyabhai
27c40b3dbe Reap stray processes
run: after we've picked up the exit status of the "main" process that
we're running, reap anything that was reparented to us before returning.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-08-01 13:30:47 -04:00
Lokesh Mandvekar
063ee76258 RPM/TMT: account for passwd binary moving to tests
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
Co-authored-by: flouthoc <flouthoc.git@gmail.com>
Signed-off-by: flouthoc <flouthoc.git@gmail.com>
2025-07-09 06:31:09 -07:00
Rahil Bhimjiani
7a482acebc Remove BUILDTAG btrfs_noversion as no longer effective
https://github.com/containers/storage/pull/2308

Signed-off-by: Rahil Bhimjiani <me@rahil.rocks>
2025-07-07 19:30:09 +05:30
Paul Holzinger
03b980a3ef rpm: build rpm with libsqlite3 tag
So we dynamically link to sqlite in fedora instead of vendoring a static
copy.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-06-11 10:31:54 +02:00
Miloslav Trmač
db336cef4d Don't BuildRequires: ostree-devel
We are not opting into the ostree backend, and it doesn't
build: https://github.com/containers/image/pull/2821 .
So, stop referencing the dependency.

Should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2025-05-31 01:38:27 +02:00
Nalin Dahyabhai
4ea64c3871 Add a dummy "runtime" that just dumps its config file
Add a dummy "runtime" that just dumps its runtime config, either the
entirety of it, or a section of it corresponding to each command line
argument.  Tests can use it to ensure that we set the right thing in the
configuration without also depending on the runtime to do as its asked,
which isn't always something we have control over.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2025-05-29 14:17:37 -04:00
Lokesh Mandvekar
c54e43a9fb [skip-ci] TMT: system tests
This commit adds TMT jobs for system tests triggered via Packit for
all active Fedora and CentOS Stream releases on x86_64.

TODO: enable aarch64 tests.

Official Fedora and CentOS Stream spec and gating test configs can be
synced from upstream by Packit, effectively upstreaming almost all
mainteenance.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2025-03-04 16:22:48 +05:30
Lokesh Mandvekar
ca957c4878 RPM: include check section to silence rpmlint
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2025-01-24 17:02:05 +05:30
Lokesh Mandvekar
6cee07f52e RPM: use default gobuild macro on RHEL
The default gobuild macro on RHEL now includes support for BUILDTAGS. So
we don't need to redefine it here.

`libtrust_openssl` buildtag will be set in the spec file for RHEL environments.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2025-01-24 16:43:03 +05:30
Lokesh Mandvekar
a1dede87eb [skip-ci] RPM: cleanup changelog conditionals
rpmautospec is now supported on all active Fedora and CentOS Stream
envs. So we don't need these conditionals anymore.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2024-12-24 15:17:29 +05:30
Kir Kolyshkin
5adb14cbfe build: rm exclude_graphdriver_devicemapper tag
Since commit c7937cd1d it is no longer necessary to have it.

[NO NEW TESTS NEEDED]

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
2024-11-11 10:49:04 -08:00
Nalin Dahyabhai
5abf038ddc Integration tests: run git daemon on a random-but-bind()able port
Use a listener helper to bind to an available-according-to-the-kernel
listening port and run a command with its stdio more or less tied to the
connection instead of trying to launch a git daemon directly using a
port number that we can only guess is available.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2024-10-21 14:39:55 -04:00
Jindrich Novy
edc1b77522 Use Epoch: 2 and respect the epoch in dependencies.
Signed-off-by: Jindrich Novy <jnovy@redhat.com>
2024-07-29 08:45:29 +02:00
Jindrich Novy
4a524737f5 fix CentOS/RHEL build - no BATS there
Signed-off-by: Jindrich Novy <jnovy@redhat.com>
2024-05-15 14:10:51 +02:00
Lokesh Mandvekar
26da74d54e [skip-ci] rpm: use go-rpm-macros supported vendoring
This removes the need for any `Provides: bundled()` we needed in spec
files.

The updated Provides will be visible in the build logs and can also be
verified with `rpm -q --provides $RPM_FILE`.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2024-03-18 17:24:55 +05:30
Lokesh Mandvekar
e53e50f7a1 [skip-ci] Makefile: update rpm target
rpkg is now deprecated. This commit makes the rpm target consistent with
the one in Podman.

Using skip-ci as we don't need to run cirrus tests for this change.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2024-03-13 19:36:45 +05:30
Lokesh Mandvekar
e997a966f8 [CI:BUILD] rpm: spdx compatible license field
The lowercase `and` in the License field isn't compatible with spdx
license format.

This commit replaces all `and` with `AND` in the License field in spec.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-08-21 09:53:22 -04:00
Lokesh Mandvekar
065b955997 [CI:BUILD] RPM: fix buildtags
buildtags mentioned as $(hack/foobar.sh) need double quotes to get
correctly read.

Fixes: #4944

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-08-11 14:42:17 -04:00
Lokesh Mandvekar
ed2a501c95 [CI:BUILD] RPM: build docs with vendored go-md2man
[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-08-09 15:09:08 -04:00
Lokesh Mandvekar
597d308801 CI:BUILD] RPM: define gobuild macro for rhel/centos stream
The current gobuild macro doesn't account for build tags on both c9s and
c8s. This is currently causing copr build failures for c9s.

Ref: https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/build/6220412/

This commit will define gobuild for all those envs until gobuild is
fixed by default.

Refs:
c9s bz: https://bugzilla.redhat.com/show_bug.cgi?id=2227328
c8s bz: https://bugzilla.redhat.com/show_bug.cgi?id=2227331

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-07-31 13:51:58 -04:00
Lokesh Mandvekar
9cc5d5e8ca [CI:BUILD] Packit: remove pre-sync action
The pre-sync action constantly breaks and is currently not possible to
reliably test until the subsequent upstream release due to limitations
in packit.

The lines being added by the action script to the downstream Fedora spec
were only meant to keep Fedora happy. But given that they provide
no tangible benefit as github notifies us of security
issues in libraries mentioned in go.mod and go.sum, along with redhat
prodsec's own magic for creating security alerts, there's absolutely
no point to having the pre-sync action run and add a layer of uncertainty.

This commit removes the pre-sync action and
`rpm/update-spec-provides.sh`.

Ref: https://github.com/containers/podman/issues/19232

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-07-14 10:20:28 -04:00
Lokesh Mandvekar
11cec85233 [CI:BUILD] Packit: downstream task script needs GOPATH
[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-07-13 10:18:09 -04:00
Lokesh Mandvekar
8b84d9b8ab [CI:BUILD] Packit: fix pre-sync action for downstream tasks
One of the reasons the last propose-downstream task failed for Fedora
was the `golist` tool wasn't available in the Packit environment.

This commit adds golist to the environment by downloading and extracting
the golist rpm.

This dependency could've been added in packit's upstream config but
there were a few blockers, so it's easiest to add them in our action
script.

Ref: https://github.com/containers/buildah/issues/4904

Also make go-md2man dependency in rpm/buildah.spec more generic

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-07-04 11:04:53 -04:00
Lokesh Mandvekar
237ac533e1 [CI:BUILD] Packit: add jobs for downstream Fedora package builds
Get rid of `buildah.spec.rpkg` in favour of
`rpm/buildah.spec` which gets synced with fedora dist-git on every
upstream release. The version in the new spec file is set to `0` by
default and gets updated by packit automatically on every packit task.

Packit will automatically create a PR on fedora dist-git on every new
upstream release. A sample PR will look like:
https://src.fedoraproject.org/rpms/container-selinux/pull-request/10#

A dry run for this can be triggered using:
`$ packit propose-downstream --local-content`

To run this command locally, you would need to have your packit
user-configuration-file set.
Ref: https://packit.dev/docs/configuration/#user-configuration-file

along with a fedora api key created at:
https://src.fedoraproject.org/settings#nav-api-tab with sufficient ACLs.

This patch incurs zero additional cost to upstream as the downstream
tasks occur only after upstream release and do not block anything
upstream.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-06-19 09:19:57 -04:00